Add create shcmea for sqlalchemy datastore #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agronholm
reviewed
Sep 21, 2024
|
You checked the boxes for having updated the documentation and added a changelog. Can you point out to me where you've done this? |
|
Please don't add unrelated changes to this PR. |
zhu0629
force-pushed
the
dev
branch
2 times, most recently
from
7997045
to
7eac782
Compare
|
I will make the necessary updates in |
zhu0629
force-pushed
the
dev
branch
2 times, most recently
from
d326891
to
3060ce9
Compare
|
I've updated |
agronholm
requested changes
Sep 22, 2024
|
Please merge from master because your force pushes are now undoing the updates I made. |
zhu0629
force-pushed
the
dev
branch
3 times, most recently
from
697b3c1
to
975a7d5
Compare
|
Could you please stop force-pushing your changes? It's causing some previous updates from |
agronholm
approved these changes
Sep 22, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add create shcmea for sqlalchemy datastore
Fixes #.
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) added which would fail without your patchdocs/, in case of behavior changes or newfeatures)
docs/versionhistory.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #999, the entry should look like this:
* Fix big bad boo-boo in the async scheduler (#999 <https://github.com/agronholm/apscheduler/issues/999>_; PR by @yourgithubaccount)If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.